Skills in Combat

Skills: Snipe, Punch of doom, Ultimate Defense, etc where is stun realy not working we try it with geodata after with out geodata its very strange. Please fix it.

Could you reupload video please?
Also, have you updated properly?
Latest update had to do with immobilizing skills.

Yes is from last rev 505  but i fix it probe was in file •EffectImmobileBuff.java

Code:

/*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2, or (at your option)
* any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
* 02111-1307, USA.
*
* http://www.gnu.org/copyleft/gpl.html
*/
package net.sf.l2j.gameserver.skills.effects;

import net.sf.l2j.gameserver.model.L2Effect;
import net.sf.l2j.gameserver.skills.Env;

/**
* @author mkizub TODO To change the template for this generated type comment go to Window - Preferences - Java - Code Style - Code Templates
*/
final class EffectImmobileBuff extends L2Effect
{
public EffectImmobileBuff(Env env, EffectTemplate template)
{
super(env, template);
}

@Override
public EffectType getEffectType()
{
return EffectType.BUFF;
}

@Override
public void onStart()
{
getEffected().setIsImmobilized(true);
}

@Override
public void onExit()

{
getEffected().setIsImmobilized(false);
}

@Override
public boolean onActionTime()
{
// just stop this effect
return false;
}
}

and here:  •L2Character.java

Code:

private Integer _IsInImobileBuff = 0;
   
   public boolean IsInImobileBuff()
   {
    return _IsInImobileBuff > 0;
   }
   
   public void setIsInImobileBuff(final boolean value)
   {
    synchronized (_IsInImobileBuff)
    {

     // Stop this if he is moving
     this.getAI().setIntention(CtrlIntention.AI_INTENTION_IDLE);

     if (value)
     {
      _IsInImobileBuff++;
     }
     else
     {
      _IsInImobileBuff--;

      if (_IsInImobileBuff < 0)
      {
       _IsInImobileBuff = 0;
      }
     }

    }

   }
   
private Integer _setIsImobilised = 0;
   
   public boolean setIsImobilised()
   {
    return _IsInImobileBuff > 0;
   }
   
   public void setIsImobilised(final boolean value)
   {
    synchronized (_IsInImobileBuff)
    {

     // Stop this if he is moving
     this.getAI().setIntention(CtrlIntention.AI_INTENTION_IDLE);

     if (value)
     {
      _IsInImobileBuff++;
     }
     else
     {
      _IsInImobileBuff--;

      if (_IsInImobileBuff < 0)
      {
       _IsInImobileBuff = 0;
      }
     }

    }

   }
   
   

Now working fine but problém is wheen u get this effect summon is get as well is bad

DanielaCZ wrote:Yes is from last rev 505  but i fix it probe was in file •EffectImmobileBuff.java

Code:

/*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2, or (at your option)
* any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
* 02111-1307, USA.
*
* http://www.gnu.org/copyleft/gpl.html
*/
package net.sf.l2j.gameserver.skills.effects;

import net.sf.l2j.gameserver.model.L2Effect;
import net.sf.l2j.gameserver.skills.Env;

/**
* @author mkizub TODO To change the template for this generated type comment go to Window - Preferences - Java - Code Style - Code Templates
*/
final class EffectImmobileBuff extends L2Effect
{
public EffectImmobileBuff(Env env, EffectTemplate template)
{
super(env, template);
}

@Override
public EffectType getEffectType()
{
return EffectType.BUFF;
}

@Override
public void onStart()
{
getEffected().setIsImmobilized(true);
}

@Override
public void onExit()

{
getEffected().setIsImmobilized(false);
}

@Override
public boolean onActionTime()
{
// just stop this effect
return false;
}
}

and here:  •L2Character.java

Code:

private Integer _IsInImobileBuff = 0;
   
   public boolean IsInImobileBuff()
   {
    return _IsInImobileBuff > 0;
   }
   
   public void setIsInImobileBuff(final boolean value)
   {
    synchronized (_IsInImobileBuff)
    {

     // Stop this if he is moving
     this.getAI().setIntention(CtrlIntention.AI_INTENTION_IDLE);

     if (value)
     {
      _IsInImobileBuff++;
     }
     else
     {
      _IsInImobileBuff--;

      if (_IsInImobileBuff < 0)
      {
       _IsInImobileBuff = 0;
      }
     }

    }

   }
   
private Integer _setIsImobilised = 0;
   
   public boolean setIsImobilised()
   {
    return _IsInImobileBuff > 0;
   }
   
   public void setIsImobilised(final boolean value)
   {
    synchronized (_IsInImobileBuff)
    {

     // Stop this if he is moving
     this.getAI().setIntention(CtrlIntention.AI_INTENTION_IDLE);

     if (value)
     {
      _IsInImobileBuff++;
     }
     else
     {
      _IsInImobileBuff--;

      if (_IsInImobileBuff < 0)
      {
       _IsInImobileBuff = 0;
      }
     }

    }

   }
   
   

Now working fine but problém is wheen u get this effect summon is get as well is bad

fix is actually very simple.

remove:

Code:

if (getEffected().removedEffectType(this))

is in EffectImmobileBuff .java

yes i have it :-)

DanielaCZ wrote:yes i have it :-)

useful to others=)

Is this really the problem?

Yes and in L2Character yava only intenger public boolean IsInImobileBuff() { return _IsInImobileBuff > 0; } public void setIsInImobileBuff(final boolean value) { synchronized (_IsInImobileBuff) { after skoll work perfect but now is problém with summon because if player use skill UD and he only stay summon stay as well this is bad because if i have mod inmbobile my summon must will free for fight.

DanielaCZ wrote:Yes and in L2Character yava only intenger public boolean IsInImobileBuff()   {    return _IsInImobileBuff > 0;   }      public void setIsInImobileBuff(final boolean value)   {    synchronized (_IsInImobileBuff)    {  after skoll work perfect but now is problém with summon because if player use skill UD and he only stay summon stay as well this is bad because if i have mod inmbobile my summon must will free for fight.

You can not why not add L2Character and will work fine and I have personally without any problems)