Block trade in combat

as was the annoying guy with macro that stood sending trade the middle of pvps and was even more boring in olly, it would be good to add a mod to lock it.

yusuketh wrote:as was the annoying guy with macro that stood sending trade the middle of pvps and was even more boring in olly, it would be good to add a mod to lock it.

There is already a check for a range of 150.
I guess it happened to you face to face.
More checks for this would mess trade system, so i' ll probably add trade to /block command.
Thanks for reporting.

go net.sf.l2j.gameserver.clientpackets.TradeRequest.java

find this lines

Code:


L2PcInstance partner = (L2PcInstance) target;
 if (partner.isInOlympiadMode() || player.isInOlympiadMode())
 {
 player.sendMessage("You or your target cant request trade in Olympiad mode.");
 return;
 }


and paste this below

Code:


if (partner.isInCombat())
 {
 player.sendMessage("You can't trade while target is in combat");
 return;
 }


I would avoid doing such a check, because it will have some more restrictions that might be unwanted.
I altered /block & /allblock commands, so as to block trade, too.

Thanks a lot for reporting.