[617] Private Store Bugs [FIXED]

1. P1 requests trade to P2
2. P2 confirms trade request from P1
3. P1 put item at trade windows and accepts the trade.
4. P1 open Private Store (/vendor) and starts to sell item.
5. P2 accepts the trade.

Error in GS

Code:

Client: [Character: ImprovisE[268475282] - Account: 123456 - IP: 127.0.0.1] - Fa
iled running: [C] 73 RequestPrivateStoreManageSell - L2J Server Version: ${l2j.r
evision} - DP Revision: ${l2jdp.revision} ; null
java.util.ConcurrentModificationException
        at java.util.ArrayList$Itr.checkForComodification(Unknown Source)
        at java.util.ArrayList$Itr.next(Unknown Source)
        at net.sf.l2j.gameserver.model.TradeList.updateItems(TradeList.java:464)

        at net.sf.l2j.gameserver.network.serverpackets.PrivateStoreManageListSel
l.<init>(PrivateStoreManageListSell.java:38)
        at net.sf.l2j.gameserver.network.clientpackets.RequestPrivateStoreManage
Sell.runImpl(RequestPrivateStoreManageSell.java:75)
        at net.sf.l2j.gameserver.network.clientpackets.L2GameClientPacket.run(L2
GameClientPacket.java:68)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
        at java.lang.Thread.run(Unknown Source)

So, P1 is selling (or buying) item that he doesn't have in his inventory.
Ofc, he can't sell it (not dupe) but it will be better if player can't open private store on state of trading with another player.

After some manipulations you can sell equipped item.

In similar way, you can buy item that you don't have in inventory.

Fixed. Thanks for reporting.

Great, it work's!
Same visual bug can be used with warehouse.
I have serious doubts will someone will use this on live server, but anyway it is possible.
As you have already said there is no safety threat in this kind of visual bugs.

Added more private store checks in revision 622.
Thanks for reporting.