[Share] Custom subclass configuration. More than 3 subs.

Hello , today's share is a custom subclass configuration for those who want to have more than 3 sub class in their server and <ALSO> they can enable or disable the option of keeping all subclass skills .
Lets begin.......


net.sf.l2j.gameserver.model.actor.instance.L2PcInstance.java

Code:


private static final String RESTORE_SKILLS_FOR_CHAR = "SELECT skill_id,skill_level FROM character_skills WHERE char_obj_id=? AND class_index=?";
+/** The Constant RESTORE_SKILLS_FOR_CHAR_ALT_SUBCLASS. */
+private static final String RESTORE_SKILLS_FOR_CHAR_ALT_SUBCLASS = "SELECT skill_id,skill_level FROM character_skills WHERE char_obj_id=? ORDER BY (skill_level+0)";


-try
-        {
-            // Retrieve all skills of this L2PcInstance from the database
-            con = L2DatabaseFactory.getInstance().getConnection();
-            PreparedStatement statement = con.prepareStatement(RESTORE_SKILLS_FOR_CHAR);
-            statement.setInt(1, getObjectId());
-            statement.setInt(2, getClassIndex());
-            ResultSet rset = statement.executeQuery();
-
-            // Go though the recordset of this SQL query
-            while (rset.next())
-            {
-                int id = rset.getInt("skill_id");
-                int level = rset.getInt("skill_level");
-
-                if (id > 9000)
-                    continue; // fake skills for base stats
-
-                // Create a L2Skill object for each record
-                L2Skill skill = SkillTable.getInstance().getInfo(id, level);
-
-                // Add the L2Skill object to the L2Character _skills and its Func objects to the calculator set of the L2Character
-                super.addSkill(skill);
-            }
-
-           rset.close();
-            statement.close();
-        }

+try
+ {
+ if (!Config.KEEP_SUBCLASS_SKILLS)
+ {
+ // Retrieve all skills of this L2PcInstance from the database
+ con = L2DatabaseFactory.getInstance().getConnection();
+ PreparedStatement statement = con.prepareStatement(RESTORE_SKILLS_FOR_CHAR);
+ statement.setInt(1, getObjectId());
+ statement.setInt(2, getClassIndex());
+ ResultSet rset = statement.executeQuery();
+
+ // Go though the recordset of this SQL query
+ while (rset.next())
+ {
+ int id = rset.getInt("skill_id");
+ int level = rset.getInt("skill_level");
+
+ if (id > 9000)
+ {
+ continue; // fake skills for base stats
+ }
+
+ // Create a L2Skill object for each record
+ L2Skill skill = SkillTable.getInstance().getInfo(id, level);
+
+ // Add the L2Skill object to the L2Character _skills and its Func objects to the calculator set of the L2Character
+ super.addSkill(skill);
+ }
+
+ rset.close();
+ statement.close();
+ rset = null;
+ statement = null;
+ }
+ else
+ {
+ // Retrieve all skills of this L2PcInstance from the database
+ con = L2DatabaseFactory.getInstance().getConnection();
+ PreparedStatement statement = con.prepareStatement(RESTORE_SKILLS_FOR_CHAR_ALT_SUBCLASS);
+ statement.setInt(1, getObjectId());
+ ResultSet rset = statement.executeQuery();
+
+ // Go though the recordset of this SQL query
+ while (rset.next())
+ {
+ int id = rset.getInt("skill_id");
+ int level = rset.getInt("skill_level");
+
+ if (id > 9000)
+ {
+ continue; // fake skills for base stats
+ }
+
+ // Create a L2Skill object for each record
+ L2Skill skill = SkillTable.getInstance().getInfo(id, level);
+
+ // Add the L2Skill object to the L2Character _skills and its Func objects to the calculator set of the L2Character
+ super.addSkill(skill);
+ }
+
+ rset.close();
+ statement.close();
+ rset = null;
+ statement = null;
+ }
+
+ }


-if (getTotalSubClasses() == 3 || classIndex == 0)
+if ((getTotalSubClasses() == Config.MAX_SUBCLASS) || (classIndex == 0))


net.sf.l2j.gameserver.model.actor.instance.L2VillageMasterInstance.java

Code:


// Avoid giving player an option to add a new sub class, if they have three already.
- if (player.getTotalSubClasses() == 3)
+ if (player.getTotalSubClasses() == Config.MAX_SUBCLASS)


net.sf.l2j.Config.java

Code:



 public static int AUTO_REWARD_COUNT;
+ public static int MAX_SUBCLASS;
+ public static boolean KEEP_SUBCLASS_SKILLS;

AUTO_REWARD_COUNT = Integer.parseInt(customSettings.getProperty("AutoRewardCount", "1000"));
+MAX_SUBCLASS = Integer.parseInt(customSettings.getProperty("MaxSubClasses", "3"));
+KEEP_SUBCLASS_SKILLS = Boolean.parseBoolean(customSettings.getProperty("KeepSubClassSkills", "False"));


gameserver/config/custom.properties

Code:


# ------------------------------------------------------------
# SubClass Configuration L2JLisvus-c4
# ------------------------------------------------------------
#Max allowed subclass for a player
#Default : 3
MaxSubClasses = 3
#Enable/Disable custom subclass option
#If True then player will keep all the skill from all subclass
#Default: False
KeepSubClassSkills = False


PasteBin: http://pastebin.com/GyF6eaN5

Give me feedback because i tested and its working for rev.453.

tested in haste... and it seems its working with out problem, thanks and keep sharing...

dont work, give me an error, in game.

With your post you don't help us to solve your error. Please show us what kind of error you get ingame.

This my error, y compile ok, no error, when i talk with npc, add subclass, chose anyone. Give me this.

Make sure that you removed only the lines that i have past above and not new lines that you added in the addSubClass method.

I did exactly what you posted.

The issue is that the sub class does it, but not low level and class changes as you should be.

But to throw that error.

But if volves the npc, put change class, you can see the sub that choice, it and if there if choose recent class changes you and makes you level 40.

It works like this? I do not think, I think when you talk and the sub choose automatically changes your class and level.

dandiarena wrote:I did exactly what you posted.

The issue is that the sub class does it, but not low level and class changes as you should be.

But to throw that error.

But if volves the npc, put change class, you can see the sub that choice, it and if there if choose recent class changes you and makes you level 40.

It works like this? I do not think, I think when you talk and the sub choose automatically changes your class and level.

Please can you explain this line better , because i don't understand what have you wrote there.

and here is a video how to add the code and also the results

when you talk to gran master, and select a class, automaticaly give you the chosen class and lvl 40.

But my problem its that, dont change class and give lvl 40, when select class.

if i talk again to master class, and select change subclass, appeared the subclass that i chose after, when you click, yes change class and get lvl 40.

you undestand now?

Yes , please check the video. If you have done any other changes in L2VillageMasterInstance or L2PcInstance before my code , please change the lines that i am showing in the video.

im downloading the video now, i try, and then i tell you

mystogan64 wrote:

i do all this, but give me the same error, cant change and give me lvl 40, this error in console that show you before.

i think its a little problem in l2pcinstance, but i see your video lowly and i make the same thinks but dontwork for me u.u

i download new svn again, and edit, but the same error too.

Added max subclasses part to trunk.
Thanks a lot.

the acumulate skills work fine..but its not good acumulate passives you can update the code?
here look castingnotgood

xbacox2010 wrote:the acumulate skills work fine..but its not good acumulate passives you can update the code?
here look castingnotgood

this have a simple solution, or put anti light armor passive skills in magic class.

or update skill light armor mastery 227 lvl 52 to all skill call light armor mastery in your navicat skill_tree.

how edit the values that you saying

Well the first part its simple, i used much because i like stuck servers and this problem its the firts.

In the navicat, add new query, and put this...

UPDATE `skill_trees` SET `skill_id`='227' WHERE (`name`='Light Armor Mastery');
UPDATE `skill_trees` SET `skill_id`='231' WHERE (`name`='Heavy Armor Mastery');

This update all skills to this id skill from all skills that have this names

This works good, test it and tell me.

[Err] 1064 - You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'UPDATE `skill_trees` SET `skill_id`='227' WHERE (`name`='Light Armor Mastery');
' at line 1

Code:

UPDATE `skill_trees` SET `skill_id`='227' WHERE (`name`='Light Armor Mastery');
UPDATE `skill_trees` SET `skill_id`='231' WHERE (`name`='Heavy Armor Mastery');

copy the same

work bad...

for me works good, try to do manually

works fine thanks

how edit only base class get third change class skills and the others any subs  the third change class not give anything skills?

is working badly for rev 470, will take some modification for the new trunk?

I hope some solution

thanks

restriction of skills de 3rd class if possible to add?