L2JLisvus

Would you like to react to this message? Create an account in a few clicks or log in to continue.

2 posters

    fix the sound of blow skills when success

    avatar
    pablo699


    Posts : 9
    Join date : 2015-05-25

    fix the sound  of blow skills when success Empty fix the sound of blow skills when success

    Post  pablo699 1st November 2019, 14:30

    Blow.java

    Code:

                      target.breakAttack();
                      target.breakCast();
                   }
                }
                
                L2PcInstance player = activeChar.getActingPlayer();
                if (player != null)
                {
    +               // Like L2OFF, when blow skill success, must sound like a critical hit
    +               target.broadcastPacket(new PlaySound("SkillSound.critical_hit_02"));
                   if (player.isInOlympiadMode() && target instanceof L2PcInstance)
                   {
                      player.dmgDealt += damage;
                   }
                   
                   player.sendPacket(new SystemMessage(SystemMessage.CRITICAL_HIT));
    DnR
    DnR
    Admin
    Admin


    Posts : 1475
    Join date : 2012-12-03
    Age : 34

    fix the sound  of blow skills when success Empty Re: fix the sound of blow skills when success

    Post  DnR 1st November 2019, 16:11

    Since when is blow sound effect not working to need such a bad fix?
    Because that's what it is. Just imagine sending an extra packet on every blow skill use.
    Anyway, we have already implemented this behaviour.


    Best regards,
    DnR
    avatar
    pablo699


    Posts : 9
    Join date : 2015-05-25

    fix the sound  of blow skills when success Empty Re: fix the sound of blow skills when success

    Post  pablo699 2nd November 2019, 00:15

    can you show me the code where is fixed?? Wink
    DnR
    DnR
    Admin
    Admin


    Posts : 1475
    Join date : 2012-12-03
    Age : 34

    fix the sound  of blow skills when success Empty Re: fix the sound of blow skills when success

    Post  DnR 2nd November 2019, 13:46

    Yeah. There is a value in MagicSkillUse responsible for animating critical attack sound.

    Check here: https://pastebin.com/Qi77xiMa

    Critical attack calculation for first target is done in L2Character, which by its turn sends this packet with calculated value.


    Best regards,
    DnR

    Sponsored content


    fix the sound  of blow skills when success Empty Re: fix the sound of blow skills when success

    Post  Sponsored content


      Current date/time is 19th May 2024, 07:02