SCRASH0 wrote:Is it normal not to regenerate mana on olly?
Players are asking why it doesn't regenerate mana on olly.
and hero is not being delivered to participants with at least 9 fights.
is giving to whoever has the most points, even if they entered the olly with 1 fight.
It seems this was simply an Interlude feature that performs a 2nd heal once the game starts.After the count for the Olympiad games begins, CP, HP, and MP are restored once more.
private static final String OLYMPIAD_GET_HEROES = "SELECT olympiad_nobles.char_id, characters.char_name "
+ "FROM olympiad_nobles, characters WHERE characters.obj_Id = olympiad_nobles.char_id "
+ "AND olympiad_nobles.class_id = ? AND olympiad_nobles.competitions_done >= 5 AND olympiad_nobles.competitions_won > 0 "
+ "ORDER BY olympiad_nobles.olympiad_points DESC, olympiad_nobles.competitions_done DESC";
DnR wrote:SCRASH0 wrote:Is it normal not to regenerate mana on olly?
Players are asking why it doesn't regenerate mana on olly.
and hero is not being delivered to participants with at least 9 fights.
is giving to whoever has the most points, even if they entered the olly with 1 fight.
Chronicle 4 rules for Olympiad were different than newer chronicles.
1) About the regenerate thing, we didn't implement it on purpose. That was due to bad information from retail website.
It seems this was simply an Interlude feature that performs a 2nd heal once the game starts.After the count for the Olympiad games begins, CP, HP, and MP are restored once more.
I'll add the missing heal as soon as possible.
2) Regarding hero computation, one needs at least 5 fights and at least 1 win. Then, it's up to the points.
This is the query that performs those checks:
- Code:
private static final String OLYMPIAD_GET_HEROES = "SELECT olympiad_nobles.char_id, characters.char_name "
+ "FROM olympiad_nobles, characters WHERE characters.obj_Id = olympiad_nobles.char_id "
+ "AND olympiad_nobles.class_id = ? AND olympiad_nobles.competitions_done >= 5 AND olympiad_nobles.competitions_won > 0 "
+ "ORDER BY olympiad_nobles.olympiad_points DESC, olympiad_nobles.competitions_done DESC";
BR,
DnR
SCRASH0 wrote:
just change this 5 by 9?
See: https://legacy-lineage2.com/news/chronicle4_02.html
C4 Notes
The Hero will be the individual who has accumulated the most Olympiad points according to their main class, has competed more than 5 times in that period, and claimed at least 1 victory. The Hero will be placed in stand-by mode and exclusive abilities and weaponry are removed after the one month period.
C5 Notes
When Olympiad points, number of wins, and winning percentage are all the same, then there will be no Hero in each class. However, the basic requirements to be a Hero, which are that the character participate in 5 games and should have at least one victory, remain the same as in Chronicle 4.
DnR wrote:SCRASH0 wrote:
just change this 5 by 9?
Why change it if it's correct?
See: https://legacy-lineage2.com/news/chronicle4_02.html
C4 Notes
The Hero will be the individual who has accumulated the most Olympiad points according to their main class, has competed more than 5 times in that period, and claimed at least 1 victory. The Hero will be placed in stand-by mode and exclusive abilities and weaponry are removed after the one month period.
C5 Notes
When Olympiad points, number of wins, and winning percentage are all the same, then there will be no Hero in each class. However, the basic requirements to be a Hero, which are that the character participate in 5 games and should have at least one victory, remain the same as in Chronicle 4.
If you still plan to customize it, you have to change competitions_done to 9 for all queries that use it, and remove competitions_won check if you want to disregard the minimum wins of 1.
DnR wrote:SCRASH0 wrote:Is it normal not to regenerate mana on olly?
Chronicle 4 rules for Olympiad were different than newer chronicles.
1) About the regenerate thing, we didn't implement it on purpose. That was due to bad information from retail website.
It seems this was simply an Interlude feature that performs a 2nd heal once the game starts.After the count for the Olympiad games begins, CP, HP, and MP are restored once more.
I'll add the missing heal as soon as possible.
BR,
DnR
- Code:
### Eclipse Workspace Patch 1.0
#P core
diff --git java/net/sf/l2j/gameserver/model/olympiad/OlympiadGame.java java/net/sf/l2j/gameserver/model/olympiad/OlympiadGame.java
index e49fd73..b6ab9a2 100644
--- java/net/sf/l2j/gameserver/model/olympiad/OlympiadGame.java
+++ java/net/sf/l2j/gameserver/model/olympiad/OlympiadGame.java
@@ -737,6 +737,11 @@
player.sendPacket(sm);
}
+ // Heal Player fully
+ player.setCurrentCp(player.getMaxCp());
+ player.setCurrentHp(player.getMaxHp());
+ player.setCurrentMp(player.getMaxMp());
+
player.dmgDealt = 0;
}
}
SCRASH0 likes this post
henrique wrote:DnR wrote:SCRASH0 wrote:Is it normal not to regenerate mana on olly?
Chronicle 4 rules for Olympiad were different than newer chronicles.
1) About the regenerate thing, we didn't implement it on purpose. That was due to bad information from retail website.
It seems this was simply an Interlude feature that performs a 2nd heal once the game starts.After the count for the Olympiad games begins, CP, HP, and MP are restored once more.
I'll add the missing heal as soon as possible.
BR,
DnR
- Code:
### Eclipse Workspace Patch 1.0
#P core
diff --git java/net/sf/l2j/gameserver/model/olympiad/OlympiadGame.java java/net/sf/l2j/gameserver/model/olympiad/OlympiadGame.java
index e49fd73..b6ab9a2 100644
--- java/net/sf/l2j/gameserver/model/olympiad/OlympiadGame.java
+++ java/net/sf/l2j/gameserver/model/olympiad/OlympiadGame.java
@@ -737,6 +737,11 @@
player.sendPacket(sm);
}
+ // Heal Player fully
+ player.setCurrentCp(player.getMaxCp());
+ player.setCurrentHp(player.getMaxHp());
+ player.setCurrentMp(player.getMaxMp());
+
player.dmgDealt = 0;
}
}
SCRASH0 wrote:EVEN BEING THAT WAY.
THERE ARE PLAYERS WHO PLAYED A SINGLE FIGHT AND WON HERO
DnR wrote:SCRASH0 wrote:EVEN BEING THAT WAY.
THERE ARE PLAYERS WHO PLAYED A SINGLE FIGHT AND WON HERO
The heal part was fixed: https://gitlab.com/TheDnR/l2j-lisvus/-/commit/5e717d89b40cb62d22d7e7e6af72e38ab7bc90ae
Regarding the one-win heroes, this shouldn't be possible and I wonder how you confirmed this.
Here is my advise. Keep a backup of `olympiad_nobles` sql table right before next heroes are formed.
Then, we can see what's wrong and try to find a solution if needed.
BR,
DnR
SCRASH0 wrote:DnR wrote:SCRASH0 wrote:EVEN BEING THAT WAY.
THERE ARE PLAYERS WHO PLAYED A SINGLE FIGHT AND WON HERO
The heal part was fixed: https://gitlab.com/TheDnR/l2j-lisvus/-/commit/5e717d89b40cb62d22d7e7e6af72e38ab7bc90ae
Regarding the one-win heroes, this shouldn't be possible and I wonder how you confirmed this.
Here is my advise. Keep a backup of `olympiad_nobles` sql table right before next heroes are formed.
Then, we can see what's wrong and try to find a solution if needed.
BR,
DnR
me and my players confirmed this,
because a player was a single fight to win hero.
and I confirmed in the table that it was just a fight
competitions_won = 0
competitions_done = 1
competitions_lost = 0
|
|
|